Core Commiter Weekly Interlock - March 27th,2017
0). 2.1.0 Signoff - PipeLine is green. With new naming convention the actual "version bump" doesn't get put on until after Monday CC meeting, any code merged into master doesn't get regression tested however when we bump the version we get the weekend merges into the release.
Former user (Deleted) would like to look at the scripts to see if there is a way to modify the process. The current 2.1.0 release does not have this concern, the last PR/Merge went in late Friday. Thus regression testing would have been ran against this code. Good to version bump 2.1.0
Amy Mullins to get real hardware added to the regression testing. An issue was seen on real hardware Amy to open up RAC issue, doesn't believe this is new to 2.1.0
1) Merge training - need to set up a confluence page that summarize role of a CC and what it takes to be a CC. Have a meeting with each Dev team and ??? to walk through what it takes to be a CC. Idea being that we can train more dev engineers so they can have the power to commit after a PR passes. Avoids having all PR merging go through a small group of CC.
Page is created, what are next steps?
RackHD Code Review and Merge Process
AI all to look at ^^^ page and mak
2) Discuss PR process to avoid failures when PR passes gates but doesn't get merged right away. RAC-4660 - Getting issue details... STATUS assigned this automation to Former user (Deleted)
3) Discuss the exact process of what failures result in merge freeze and how to clearly state so all CCs know for sure. Maybe a way to automate this (i.e. MasterCI Jenkins build automatically results in a pinned message in the rackhdcc slack channel)
If Master CI is red then a P1 is to be opened and merge freeze goes into affect. Former user (Deleted) to look at Zapier to see if way to automate slack message and possibly pinning the freeze message to RackHDCC channel
4) How are we using coveralls as a PR gate? Merges are occurring even when coverage is decreasing. What are our rules? Is it OK to merge even with a decrease and is there a floor as far as percentage of coverage?
The rule is to not merge if coverage drops, however there are situations that could cause us to make an exception (for example disabling of 1.1 API resulted in coverage drop - testing was disabled before code was removed)
trivial/negligible drop is acceptable.
5) Leo Zhang: Create new repo "image-service" RI-61 Documentation needed on how to use the different styles of OS installation. AI Leo Zhang to provide document. Need to add this style to FIT tests. AI norton luo to add tests to FIT (Regression and smoke)
Felix: I don't have permission to create repo in RackHD organization. Tim Larson, I see you are the OrgMaintainers, could you please do me a favor?
Completed
6). Former user (Deleted): Minimize Environment for CI Test: Minimize Environment For CI Test.pptx
AI Thomas Sullivan Tom Capirchio do we post an OVA anywhere for outside of Dell/EMC? Do we want them to?
Tom C suggested the last 5 sprint releases to be kept. Are we in agreement? Enough space?
There are consumers that need daily OVA's. Are there other locations we can store these daily OVA's Former user (Deleted) Possible Virtustream or pay for more bintray.
7) Former user (Deleted): Whether enable Code Climate for PR gate check? https://github.com/RackHD/on-core/pull/264
- Example PR: https://github.com/yyscamper/on-core/pull/7
- Example PR Analysis report: https://codeclimate.com/github/yyscamper/on-core/pull/7
- RackHD master report (on-core): https://codeclimate.com/github/RackHD/on-core
- Browser extension: https://codeclimate.com/browser-extension
- Available Analysis Engines: https://docs.codeclimate.com/docs/list-of-engines
- Replace JSHint with ESLint (http://eslint.org/)?
- We need to cleanup all existing static analysis issues before using code climate and ESLint
AI Former user (Deleted) to look at configuration options for code climate to make sure that it can give us some useful information. Are there other options besides hound and code climate?
Felix: Former user (Deleted), From my example code climate configuration (https://github.com/yyscamper/on-core/blob/d647ea9a5cb4df4e384f8f83d1bf8e9e9025b7f7/.codeclimate.yml), the duplicated code check is disabled.
AI Former user (Deleted) to look into if it supports Java and see if it can be used against the mustang code base.
Felix: Former user (Deleted) I checked the code climate doc, it supports Java using PMD engine (see https://docs.codeclimate.com/docs/pmd), but it is still in Beta version.
8). Naming conventions for daily releases - contain the previous release candidate plus date 1.3.0-20170208 How do we handle multiple delivery in a day?
AI Former user (Deleted) and Former user (Deleted) to send out there thoughts on this. To discuss at the next CC meeting
Selenium was verified against the on-webui can this also be used against swagger (AI Former user (Deleted))
(Former user (Deleted): Exchanged information with Muqeeth Kowkab who confirmed that Selenium can also be used with swagger-ui. Was confirmed with Firefox addon to Selenium IDE. Should also work with Chrome WebDriver).