Core Commiter Weekly Interlock - April 3,2017
1) Quality Review Board issues - is this RAC a P1 ? https://rackhd.atlassian.net/browse/RAC-4643
Update not a P1 2.6.10 does not work, 2.4.9 works, does 3.X work? AI Former user (Deleted) to follow up with Thomas Sullivan on a knowledge base to document this
AI Amy Mullins to update Rac Issue with above info
- Nightly build discussion: http://rackhdci.lss.emc.com/job/Regression-baremetal/ Once we have stability of the testing on real hardware and we can add more hardware we should look to add this to the nightly regression suite.
- Discussion on "Dojo style" dev engagements within the broader RackHD org and CC team alignment on processes to follow .
2). 2.1.0 Signoff - PipeLine is green. With new naming convention the actual "version bump" doesn't get put on until after Monday CC meeting, any code merged into master doesn't get regression tested however when we bump the version we get the weekend merges into the release.
Former user (Deleted) would like to look at the scripts to see if there is a way to modify the process. The current 2.1.0 release does not have this concern, the last PR/Merge went in late Friday. Thus regression testing would have been ran against this code. Good to version bump 2.1.0
Amy Mullins to get real hardware added to the regression testing. An issue was seen on real hardware Amy to open up RAC issue, doesn't believe this is new to 2.1.0
Promoted releases (every 2 week release) how do we make these faster eventually get down to our regression testing/packaging/labeling complete daily thus having daily releases.
Look at Peter Pan email about potential process change to do the version bump on Friday at time of build. Group to follow up with that email.
Should we be promoting weekly?
3) Merge training - need to set up a confluence page that summarize role of a CC and what it takes to be a CC. Have a meeting with each Dev team and ??? to walk through what it takes to be a CC. Idea being that we can train more dev engineers so they can have the power to commit after a PR passes. Avoids having all PR merging go through a small group of CC.
Page is created, what are next steps?
RackHD Code Review and Merge Process
AI all to look at ^^^ page and mak
4) Former user (Deleted): Whether enable Code Climate for PR gate check? https://github.com/RackHD/on-core/pull/264
- Example PR: https://github.com/yyscamper/on-core/pull/7
- Example PR Analysis report: https://codeclimate.com/github/yyscamper/on-core/pull/7
- RackHD master report (on-core): https://codeclimate.com/github/RackHD/on-core
- Browser extension: https://codeclimate.com/browser-extension
- Available Analysis Engines: https://docs.codeclimate.com/docs/list-of-engines
- Replace JSHint with ESLint (http://eslint.org/)?
- We need to cleanup all existing static analysis issues before using code climate and ESLint
AI Former user (Deleted) to look at configuration options for code climate to make sure that it can give us some useful information. Are there other options besides hound and code climate?
Felix: Former user (Deleted), From my example code climate configuration (https://github.com/yyscamper/on-core/blob/d647ea9a5cb4df4e384f8f83d1bf8e9e9025b7f7/.codeclimate.yml), the duplicated code check is disabled.
AI Former user (Deleted) to look into if it supports Java and see if it can be used against the mustang code base.
Felix: Former user (Deleted) I checked the code climate doc, it supports Java using PMD engine (see https://docs.codeclimate.com/docs/pmd), but it is still in Beta version.
UPDATE 4/3/2017 -
5) email about RackHD and its alerts - latest jsd for the incoming message from rackHD
continue discussion through email.